Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

script/tool_runner.sh has only been intended for CI usage for quite a while, but it still lives in a prominent non-CI location which has been a source of confusion for developers (e.g., people looking at how CI is running things, and reasonably assuming that since the script isn't in a CI-specific location, it's for general use). While running it for simple cases works, it conflicts with any package selection, which is common thing to want to control when running locally.

This makes the following changes:

  • Move the script into the .ci directory
  • Adds explicit comments that it's not designed for local use, with a pointer to the corresponding local command
  • Removes a stale reference to external-to-the-repo use of tool_runner.sh, as that usage no longer exists
    • Also consolidates and updates the links to the external scripts
  • Updates a couple of CONTRIBUTING.md comments that still said to run tool_runner.sh
  • Opportunistically cleans up some tooling references to .cirrus.yml, found while cleaning up comments in tool_runner.sh and checking for other references.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2024
@auto-submit auto-submit bot merged commit 9382257 into flutter:main Feb 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 7, 2024
flutter/packages@1a5a7ce...e4ea6bf

2024-02-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 0b5cd50 to e6ba809 (12 revisions) (flutter/packages#6066)
2024-02-06 stuartmorgan@google.com [tool] Update to Dart 3 (flutter/packages#6030)
2024-02-06 stuartmorgan@google.com [ci] Move tool_runner.sh (flutter/packages#6038)
2024-02-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/packages#6063)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants